feat: move all custom JS to afterInteractive #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌿 Documentation Preview
|
Brodan
reviewed
Jul 29, 2025
| - path: assets/dashboard-referral.js | ||
| strategy: beforeInteractive | ||
| strategy: afterInteractive |
There was a problem hiding this comment.
wait it looks like below you are removing this script entirely? can't this be removed from docs.yml too then?
There was a problem hiding this comment.
Ah no! Sorry I should have made that clearer. I'm just removing the TS source code of this script since it's not really needed anymore (assuming we aren't making regular changes). The actual script we're using here is a transpiled version in assets.
I can leave it if you prefer but seems like bad practice to have both source and transpiled version in source control
CodesMcCabe
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we have some JS which is slowing down the site. For some reason this was set as
beforeInteractivewhich means its render-blocking. So what if we just like, didn't do that.Related Issues
Changes Made
afterInteractiveTesting
pnpm run validate)